alamar commented on a change in pull request #8897:
URL: https://github.com/apache/ignite/pull/8897#discussion_r613113785
##########
File path:
modules/azure/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/azure/TcpDiscoveryAzureBlobStoreIpFinder.java
##########
@@ -358,6 +368,26 @@ private void removeContainer(String containerName) {
}
}
+ /** Handles stripping the interface name for IpV6 addresses */
+ private static void handleInterfaceStripping(Collection<InetSocketAddress>
addrs) {
Review comment:
We do not need to remove IPv6 addresses from finder, we only need to
remove "%.*$" from the addresses before saving them to the storage.
##########
File path:
modules/azure/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/azure/TcpDiscoveryAzureBlobStoreIpFinder.java
##########
@@ -78,6 +80,12 @@
@LoggerResource
private IgniteLogger log;
+ /** System property which defines if the system is set to use Ipv4 */
+ private static final String PREFER_IPV4 = "java.net.preferIPv4Stack";
+
+ /** Regex which allows matching interface names for Ipv6 */
+ private static final String INTERFACE_REGEX = "^/\\[[^\\]]*]:47500$";
Review comment:
Also, it is not appropriate to hard code port here, since it may change.
##########
File path:
modules/azure/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/azure/TcpDiscoveryAzureBlobStoreIpFinder.java
##########
@@ -358,6 +368,26 @@ private void removeContainer(String containerName) {
}
}
+ /** Handles stripping the interface name for IpV6 addresses */
+ private static void handleInterfaceStripping(Collection<InetSocketAddress>
addrs) {
Review comment:
Then they should be saved all right and also read all right on remote
side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
