olegbevz commented on a change in pull request #8999:
URL: https://github.com/apache/ignite/pull/8999#discussion_r613273052
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Query/Linq/CacheLinqTest.Strings.cs
##########
@@ -110,6 +110,30 @@ public void TestStrings()
// String + int
CheckFunc(x => x + 10, strings);
+
+ // string.Compare(string strA, string strB)
+ CheckWhereFunc(x => string.Compare(x, "Person_1300") < 0, strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300") > 0, strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300") == 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300") < 0, strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300") > 0, strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300") == 0,
strings);
+
+ // string.Compare(string strA, string strB, true)
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", true) < 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", true) > 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", true) == 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", true) < 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", true) > 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", true) == 0,
strings);
+
+ // string.Compare(string strA, string strB, false)
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", false) < 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", false) > 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "Person_1300", false) == 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", false) < 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", false) > 0,
strings);
+ CheckWhereFunc(x => string.Compare(x, "person_1300", false) == 0,
strings);
Review comment:
agree, added tests for null arguments, also had to modify sql query with
nvl2 operator(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
