sashapolo commented on a change in pull request #94:
URL: https://github.com/apache/ignite-3/pull/94#discussion_r613348496
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeTopologyService.java
##########
@@ -52,31 +52,50 @@ void setLocalMember(Member member) {
*/
void onMembershipEvent(MembershipEvent event) {
ClusterNode member = fromMember(event.member());
- for (TopologyEventHandler handler : getEventHandlers()) {
- switch (event.type()) {
- case ADDED:
- members.put(member.name(), member);
- handler.onAppeared(member);
+ String memberName = member.name();
+
+ boolean appeared = false;
+ boolean disappeared = false;
+
+ switch (event.type()) {
+ case ADDED:
+ members.put(memberName, member);
+
+ appeared = true;
+
+ break;
- break;
+ case LEAVING:
+ members.remove(memberName);
- case LEAVING:
- members.remove(member.name());
+ disappeared = true;
- handler.onDisappeared(member);
+ break;
- break;
+ case REMOVED:
+ if (members.containsKey(memberName)) {
+ members.remove(memberName);
- case REMOVED:
- case UPDATED:
- // No-op.
- break;
+ disappeared = true;
+ }
- default:
- throw new IgniteInternalException("This event is not
supported: event = " + event);
+ break;
- }
+ case UPDATED:
+ // No-op.
+ break;
+
+ default:
+ throw new IgniteInternalException("This event is not
supported: event = " + event);
+
+ }
+
+ for (TopologyEventHandler handler : getEventHandlers()) {
Review comment:
We will re-iterate over all event handlers even if we've received a
non-interesting message (e.g. `UPDATED`). I think we can optimize this
approach. For example, I would suggest using two methods (`fireAppearedEvent`
and `fireDissapearedEvent`) and get rid of `appeared` and `disappeared` flags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
