ololo3000 commented on a change in pull request #8892:
URL: https://github.com/apache/ignite/pull/8892#discussion_r614279563
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/IgniteAuthenticationProcessor.java
##########
@@ -212,53 +230,33 @@ else if (msg instanceof UserAuthenticateResponseMessage)
new LinkedBlockingQueue<>());
}
- /**
- * On cache processor started.
- */
- public void cacheProcessorStarted() {
- sharedCtx = ctx.cache().context();
- }
-
/** {@inheritDoc} */
@Override public void stop(boolean cancel) throws IgniteCheckedException {
- if (!isEnabled)
- return;
-
- ctx.io().removeMessageListener(GridTopic.TOPIC_AUTH, ioLsnr);
+ if (ioLsnr != null)
Review comment:
This component can be stopped before ioLsnr is initialized - for example
in case when exception is thrown during node startup by other components. And
we will face NPE. As I see null check is a common practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
