nizhikov commented on a change in pull request #8998:
URL: https://github.com/apache/ignite/pull/8998#discussion_r615687858



##########
File path: 
modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/utils/IgniteAwareApplicationService.java
##########
@@ -50,7 +63,7 @@ public static void main(String[] args) throws Exception {
 
         String[] params = args[0].split(",");
 
-        boolean startIgnite = Boolean.parseBoolean(params[0]);
+        String startIgnite = params[0];

Review comment:
       Please, rewrite this to
   ```
   StartIgniteMode mode = StartIgniteMode.valueOf(params[0]);
   ...
   if (mode == NODE) {
   ...
   }
   else if (mode == THIS_CLIENT) {
   ...
   }
   else if (mode == NONE) {
   }
   else
       throw new IllegalArgumentException("Unknown mode " + mode);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to