ololo3000 commented on a change in pull request #8892:
URL: https://github.com/apache/ignite/pull/8892#discussion_r617423284
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/security/IgniteSecurity.java
##########
@@ -126,4 +127,33 @@ public default void authorize(SecurityPermission perm)
throws SecurityException
* false if it's used a default NoOp implementation.
*/
public boolean enabled();
+
+ /**
+ * Creates user with the specified login and password.
+ *
+ * @param login Login of the user to be created.
+ * @param pwd User password.
+ * @throws IgniteCheckedException If error occurred.
+ */
+ @IgniteExperimental
Review comment:
Reverted.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/security/GridSecurityProcessor.java
##########
@@ -133,4 +134,39 @@ public void authorize(String name, SecurityPermission
perm, SecurityContext secu
public default boolean sandboxEnabled() {
return false;
}
+
+ /**
+ * Creates user with the specified login and password.
+ *
+ * @param login Login of the user to be created.
+ * @param pwd User password.
+ * @throws IgniteCheckedException If error occurred.
+ */
+ @IgniteExperimental
Review comment:
Reverted.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/security/GridSecurityProcessor.java
##########
@@ -133,4 +134,39 @@ public void authorize(String name, SecurityPermission
perm, SecurityContext secu
public default boolean sandboxEnabled() {
return false;
}
+
+ /**
+ * Creates user with the specified login and password.
+ *
+ * @param login Login of the user to be created.
+ * @param pwd User password.
+ * @throws IgniteCheckedException If error occurred.
+ */
+ @IgniteExperimental
+ public default void createUser(String login, String pwd) throws
IgniteCheckedException {
Review comment:
Done.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
##########
@@ -1568,6 +1567,11 @@ private static DecimalFormat doubleFormat() {
private GridProcessor securityProcessor() throws IgniteCheckedException {
GridSecurityProcessor prc =
createComponent(GridSecurityProcessor.class, ctx);
+ if (cfg.isAuthenticationEnabled() && !(prc instanceof
IgniteAuthenticationProcessor)) {
Review comment:
To prevent configuration of external security plugin and Ignite
authentication at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
