agura commented on a change in pull request #105: URL: https://github.com/apache/ignite-3/pull/105#discussion_r619388097
########## File path: modules/vault/src/main/java/org/apache/ignite/internal/vault/common/WatcherImpl.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.vault.common; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.TimeUnit; +import org.apache.ignite.lang.IgniteUuid; +import org.jetbrains.annotations.NotNull; + +/** + * Implementation of vault {@link Watcher}. + */ +public class WatcherImpl implements Watcher { + /** Queue for changed vault entries. */ + private final BlockingQueue<VaultEntry> queue = new LinkedBlockingQueue<>(); + + /** Registered vault watches. */ + private final Map<IgniteUuid, VaultWatch> watches = new HashMap<>(); + + /** Flag for indicating if watcher is stopped. */ + private volatile boolean stop; + + /** Mutex. */ + private final Object mux = new Object(); + + /** Execution service which runs thread for processing changed vault entries. */ + private final ExecutorService exec; + + /** + * Default constructor. + */ + public WatcherImpl() { + exec = Executors.newFixedThreadPool(1); + + exec.execute(new WatcherWorker()); + } + + /** {@inheritDoc} */ + @Override public CompletableFuture<IgniteUuid> register(@NotNull VaultWatch vaultWatch) { + synchronized (mux) { Review comment: Private sync policy is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
