anton-vinogradov commented on a change in pull request #9008:
URL: https://github.com/apache/ignite/pull/9008#discussion_r622882923
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -190,9 +190,11 @@ def init_shared(self, node):
node.account.copy_to(os.path.join(local_shared_dir, file),
self.shared_root)
def _prepare_configs(self, node):
- config = self.config.prepare_for_env(self.globals, self.shared_root,
node, self)
+ config = self.spec \
+ .extend_config(self.config, self.globals, node, self) \
+ .prepare_for_env(self.globals, self.shared_root, node, self)
Review comment:
how about passing only `self` and `node` here?
##########
File path:
modules/ducktests/tests/ignitetest/services/utils/templates/ignite.xml.j2
##########
@@ -93,9 +95,41 @@
{% if config.client_connector_configuration %}
<property name="clientConnectorConfiguration">
<bean
class="org.apache.ignite.configuration.ClientConnectorConfiguration">
- <property name="port" value="{{
config.client_connector_configuration.port }}"/>
+ <property name="port" value="{{
config.client_connector_configuration.port }}"/>
+ <property name="sslEnabled" value="{{
config.client_connector_configuration.ssl_enabled }}"/>
+ {% if config.client_connector_configuration.ssl_enabled %}
Review comment:
any reason to have `<property name="sslEnabled" value="false"` when
!ssl_enabled?
##########
File path: modules/ducktests/tests/docker/ducker-ignite
##########
@@ -479,6 +479,11 @@ ducker_test() {
must_pushd "${ignite_dir}"
#(test mvn) && mvn package -DskipTests -Dmaven.javadoc.skip=true
-Plgpl,-examples,-clean-libs,-release,-scala,-clientDocs
must_popd
+ if [[ -n "${DUCKTAPE_EXTRA_SETUP}" ]]; then
+ echo "execing extra ducktape setup with '${DUCKTAPE_EXTRA_SETUP}'"
Review comment:
executing?
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -190,9 +190,11 @@ def init_shared(self, node):
node.account.copy_to(os.path.join(local_shared_dir, file),
self.shared_root)
def _prepare_configs(self, node):
- config = self.config.prepare_for_env(self.globals, self.shared_root,
node, self)
+ config = self.spec \
+ .extend_config(self.config, self.globals, node, self) \
Review comment:
seems you may pass only `self`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
