alievmirza commented on a change in pull request #113:
URL: https://github.com/apache/ignite-3/pull/113#discussion_r623071151
##########
File path:
modules/metastorage-client/src/main/java/org/apache/ignite/metastorage/client/MetaStorageService.java
##########
@@ -215,8 +214,8 @@
*/
// TODO: https://issues.apache.org/jira/browse/IGNITE-14269: will be
replaced by conditional multi update.
@NotNull
- CompletableFuture<Boolean> invoke(@NotNull Key key, @NotNull Condition
condition,
- @NotNull Operation success, @NotNull
Operation failure);
+ CompletableFuture<Boolean> invoke(@NotNull Condition condition,
Review comment:
Seems that we need to change javadoc as well, we're using collections now
##########
File path:
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java
##########
@@ -333,6 +342,27 @@ public synchronized void deployWatches() {
return metaStorageSvc.range(keyFrom, keyTo, revUpperBound);
}
+ /**
+ * Retrieves entries for the given key range in lexicographic order.
+ * Entries will be filtered out by the current applied revision as an
upper bound
Review comment:
Probably we should explain here what applied revision is.
##########
File path:
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java
##########
@@ -333,6 +342,27 @@ public synchronized void deployWatches() {
return metaStorageSvc.range(keyFrom, keyTo, revUpperBound);
}
+ /**
+ * Retrieves entries for the given key range in lexicographic order.
+ * Entries will be filtered out by the current applied revision as an
upper bound
+ *
+ * @param keyFrom Start key of range (inclusive). Couldn't be {@code null}.
+ * @param keyTo End key of range (exclusive). Could be {@code null}.
+ * @return Cursor built upon entries corresponding to the given range and
revision.
Review comment:
I would change javadoc for @ return, there is no given revision,
appliedRevision is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
