ibessonov commented on a change in pull request #102:
URL: https://github.com/apache/ignite-3/pull/102#discussion_r623136204
##########
File path:
modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
##########
@@ -179,11 +183,14 @@ private static void stopForcefully(ClusterService
cluster) throws Exception {
* Wrapper for cluster.
*/
private static final class Cluster {
- /** */
- private static final MessageSerializationRegistry
SERIALIZATION_REGISTRY = new MessageSerializationRegistry();
/** */
private static final ClusterServiceFactory NETWORK_FACTORY = new
ScaleCubeClusterServiceFactory();
+ /** */
+ private static final MessageSerializationRegistry
SERIALIZATION_REGISTRY = new MessageSerializationRegistry()
Review comment:
What's the hard of making them non-static? This collection won't be
garbage collected, for example, so I consider it a bad practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
