zstan commented on a change in pull request #9090:
URL: https://github.com/apache/ignite/pull/9090#discussion_r630905246



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
##########
@@ -2626,7 +2627,11 @@ private void stopGateway(DynamicCacheChangeRequest req) {
      * @param clearDbObjects If {@code false} DB objects don't removed (used 
for cache.close() on client node).
      * @return Stopped cache context.
      */
-    public GridCacheContext<?, ?> prepareCacheStop(String cacheName, boolean 
destroy, boolean clearDbObjects) {
+    @Nullable public GridCacheContext<?, ?> prepareCacheStop(

Review comment:
       no one use return result from this func, may it would be be more clear 
to change implementation to void ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to