alievmirza commented on a change in pull request #114:
URL: https://github.com/apache/ignite-3/pull/114#discussion_r631021120
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/storage/Data.java
##########
@@ -56,14 +51,7 @@ public Data(Map<String, Serializable> values, long
cfgVersion, long storageRevis
* Get version.
* @return version.
*/
- public long cfgVersion() {
- return cfgVersion;
- }
-
- /**
- * @return Storage revision.
- */
- public long storageRevision() {
- return storageRevision;
+ public long changeId() {
Review comment:
This name was proposed by @ibessonov, it is better to discuss with him
naming. About version, this `changeId` also valid for
`LocalConfigurationSrorage` as far as the mechanism for updating configuration
is common. For LocalConfigurationSrorage` it is just a counter for
configuration updates, however for `DistributedConfigurationSrorage` it is a
metastorage revision, which is actual for the current update of configuration.
I don't think that it is reasonable to refer to that in `changeId` javadoc
because this is specific for the different configuration storages
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/configuration/storage/Data.java
##########
@@ -56,14 +51,7 @@ public Data(Map<String, Serializable> values, long
cfgVersion, long storageRevis
* Get version.
* @return version.
*/
- public long cfgVersion() {
- return cfgVersion;
- }
-
- /**
- * @return Storage revision.
- */
- public long storageRevision() {
- return storageRevision;
+ public long changeId() {
Review comment:
This name was proposed by @ibessonov, it is better to discuss with him
the naming. About version, this `changeId` also valid for
`LocalConfigurationSrorage` as far as the mechanism for updating configuration
is common. For LocalConfigurationSrorage` it is just a counter for
configuration updates, however for `DistributedConfigurationSrorage` it is a
metastorage revision, which is actual for the current update of configuration.
I don't think that it is reasonable to refer to that in `changeId` javadoc
because this is specific for the different configuration storages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
