ascherbakoff commented on a change in pull request #126:
URL: https://github.com/apache/ignite-3/pull/126#discussion_r631816346
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeTopologyService.java
##########
@@ -54,37 +52,16 @@ void setLocalMember(Member member) {
void onMembershipEvent(MembershipEvent event) {
ClusterNode member = fromMember(event.member());
- String memberName = member.name();
-
- switch (event.type()) {
- case ADDED:
- members.put(memberName, member);
-
- fireAppearedEvent(member);
-
- break;
-
- case LEAVING:
- members.remove(memberName);
-
- fireDisappearedEvent(member);
+ if (event.isAdded()) {
Review comment:
LEAVING event makes sense only if we want to let the user know the node
has left intentionally - similar to NODE_LEFT event in ignite2.
Currently I see no demand in such functionality. It may be added later, if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
