dgarus commented on a change in pull request #8038:
URL: https://github.com/apache/ignite/pull/8038#discussion_r633359239
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java
##########
@@ -1343,4 +1349,43 @@ public void recoveryMode(boolean recoveryMode) {
? ForkJoinPool.commonPool()
: config().getAsyncContinuationExecutor();
}
+
+ /**
+ * Wraps executors to security aware implementations.
+ */
+ private void wrapExecutors() {
+ utilityCachePool = wrapToSecurityAware(utilityCachePool);
+ execSvc = wrapToSecurityAware(execSvc);
+ svcExecSvc = wrapToSecurityAware(svcExecSvc);
+ sysExecSvc = wrapToSecurityAware(sysExecSvc);
+ p2pExecSvc = wrapToSecurityAware(p2pExecSvc);
+ mgmtExecSvc = wrapToSecurityAware(mgmtExecSvc);
+ restExecSvc = wrapToSecurityAware(restExecSvc);
Review comment:
No, we should not.
>This code has a strong relation with the initialization order of the
executors
I don't sure what you mean.
GridKernalContextImpl gets all executors through the constructor so they
should be initialized for this moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
