alex-plekhanov commented on a change in pull request #9084:
URL: https://github.com/apache/ignite/pull/9084#discussion_r633545128
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -1149,4 +1165,80 @@ private void onError(Throwable error) {
tryClose();
}
}
+
+ /** */
+ private static class FixDependentInsertNodeShuttle extends
IgniteRelShuttle {
Review comment:
There still some "insert node" phrases in javadocs.
About "update" statement: "insert" statement as select from the same table
it's a rare case, and memory overconsumption caused by table spool not so
important here, but "update" statement will always be depended on the scan of
the updated table and table spool always will be used. But for updates, it's
not always needed. It's needed only if we modify columns used in the index we
are iterating. Perhaps it's worth to include such optimization. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
