agura commented on a change in pull request #129:
URL: https://github.com/apache/ignite-3/pull/129#discussion_r635121016
##########
File path:
modules/metastorage-client/src/main/java/org/apache/ignite/metastorage/client/MetaStorageService.java
##########
@@ -71,28 +66,28 @@
* Collection elements couldn't be {@code null}.
* @return A map of entries for given keys. Couldn't be {@code null}.
* @throws OperationTimeoutException If the operation is timed out. Will
be thrown on getting future result.
- * @see Key
+ * @see ByteArray
* @see Entry
*/
@NotNull
- CompletableFuture<Map<Key, Entry>> getAll(Collection<Key> keys);
+ CompletableFuture<Map<ByteArray, Entry>> getAll(Collection<ByteArray>
keys);
/**
* Retrieves entries for given keys and the revision upper bound.
*
* @param keys The collection of keys. Couldn't be {@code null} or empty.
* Collection elements couldn't be {@code null}.
- * @param revUpperBound The upper bound for entry revisions. Must be
positive.
+ * @param revUpperBound The upper bound for entry revisions. Must be
positive.
* @return A map of entries for given keys and maximum revision limited by
{@code revUpperBound}.
* Couldn't be {@code null}.
* @throws OperationTimeoutException If the operation is timed out. Will
be thrown on getting future result.
* @throws CompactedException If the desired revisions are removed from
the storage due to a compaction.
* Will be thrown on getting future result.
- * @see Key
+ * @see ByteArray
* @see Entry
*/
@NotNull
- CompletableFuture<Map<Key, Entry>> getAll(Collection<Key> keys, long
revUpperBound);
+ CompletableFuture<Map<ByteArray, Entry>> getAll(Collection<ByteArray>
keys, long revUpperBound);
Review comment:
Definitely agree. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
