sanpwc commented on a change in pull request #147:
URL: https://github.com/apache/ignite-3/pull/147#discussion_r639467213



##########
File path: 
modules/raft-client/src/main/java/org/apache/ignite/raft/client/service/CommandClosure.java
##########
@@ -30,14 +32,8 @@
     R command();
 
     /**
-     * Success outcome.
-     * @param res The result.
-     */
-    void success(Object res);
-
-    /**
-     * Failure outcome.
-     * @param err The error.
+     * Must be called after a command has been processed normally.
+     * @param res Execution result.
      */
-    void failure(Throwable err);
+    void result(Object res);

Review comment:
       Should we make an intention that res should be marshalable more obvious?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to