vldpyatkov commented on a change in pull request #118:
URL: https://github.com/apache/ignite-3/pull/118#discussion_r640364273
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/KVBinaryViewImpl.java
##########
@@ -172,22 +175,34 @@ public KVBinaryViewImpl(InternalTable tbl, SchemaRegistry
schemaReg) {
/** {@inheritDoc} */
@Override public Collection<Tuple> removeAll(Collection<Tuple> keys) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ Objects.requireNonNull(keys);
+
+ return sync(removeAllAsync(keys));
}
/** {@inheritDoc} */
- @Override public @NotNull CompletableFuture<Tuple>
removeAllAsync(Collection<Tuple> keys) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ @Override public @NotNull CompletableFuture<Collection<Tuple>>
removeAllAsync(Collection<Tuple> keys) {
+ Objects.requireNonNull(keys);
+
+ return tbl.deleteAll(keys.stream().map(k -> marsh.marshal(k,
null)).collect(Collectors.toList()))
+ .thenApply(this::wrap)
+ .thenApply(ts ->
ts.stream().filter(Objects::nonNull).map(TableRow::valueChunk).collect(Collectors.toList()));
}
/** {@inheritDoc} */
@Override public Tuple getAndRemove(Tuple key) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ Objects.requireNonNull(key);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
