map7000 commented on a change in pull request #9131:
URL: https://github.com/apache/ignite/pull/9131#discussion_r640429157
##########
File path: modules/ducktests/tests/ignitetest/tests/auth_test.py
##########
@@ -24,12 +24,13 @@
from ignitetest.services.utils.ignite_configuration import
IgniteConfiguration, DataStorageConfiguration
from ignitetest.services.utils.ignite_configuration.data_storage import
DataRegionConfiguration
from ignitetest.utils import ignite_versions, cluster
-from ignitetest.services.utils.ignite_configuration.discovery import
from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import
IgniteThinClientConfiguration
+from ignitetest.services.utils.ssl.client_connector_configuration import
ClientConnectorConfiguration
from ignitetest.utils.ignite_test import IgniteTest
from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
WRONG_PASSWORD = "wrong_password"
-TEST_USERNAME = "admin"
+TEST_USERNAME = "ADMIN"
Review comment:
There are 2 ways to pass username in SQL query:
1. case-sensitive
"CREATE USER \"%s\" WITH PASSWORD '%s';"
2. not case-sensitive
"CREATE USER %s WITH PASSWORD '%s';"
IMHO variant 2 looks cleaner (but username should be uppercase)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
