alievmirza commented on a change in pull request #118:
URL: https://github.com/apache/ignite-3/pull/118#discussion_r641283000
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/TableImpl.java
##########
@@ -107,12 +109,22 @@ public SchemaRegistry schemaView() {
/** {@inheritDoc} */
@Override public Collection<Tuple> getAll(Collection<Tuple> keyRecs) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ return sync(getAllAsync(keyRecs));
}
/** {@inheritDoc} */
@Override public @NotNull CompletableFuture<Collection<Tuple>>
getAllAsync(Collection<Tuple> keyRecs) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ Objects.requireNonNull(keyRecs);
Review comment:
Please add here and below @NotNull annotation and also reflect that in
TableView methods and java docs, as we did for KeyValueView.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
