sashapolo commented on a change in pull request #153:
URL: https://github.com/apache/ignite-3/pull/153#discussion_r643162119
##########
File path:
modules/metastorage-client/src/integrationTest/java/org/apache/ignite/internal/metastorage/client/ITMetaStorageServiceTest.java
##########
@@ -91,16 +85,17 @@
public static final int LATEST_REVISION = -1;
/** Factory. */
- private static final RaftClientMessageFactory FACTORY = new
RaftClientMessageFactoryImpl();
+ private static final RaftClientMessagesFactory FACTORY = new
RaftClientMessagesFactory();
/** Network factory. */
private static final ClusterServiceFactory NETWORK_FACTORY = new
TestScaleCubeClusterServiceFactory();
/** */
- private static final MessageSerializationRegistry SERIALIZATION_REGISTRY =
new MessageSerializationRegistry()
- .registerFactory(ScaleCubeMessage.TYPE, new
ScaleCubeMessageSerializationFactory())
- .registerFactory(HandshakeStartMessage.TYPE, new
HandshakeStartMessageSerializationFactory())
- .registerFactory(HandshakeStartResponseMessage.TYPE, new
HandshakeStartResponseMessageSerializationFactory());
+ private static final MessageSerializationRegistry SERIALIZATION_REGISTRY =
new MessageSerializationRegistry();
+
+ static {
Review comment:
I had the same thoughts, but I decided to stick to this style, because
it is more local (initialization is closer to the field) and requires less code
to write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
