AMashenkov commented on a change in pull request #9090: URL: https://github.com/apache/ignite/pull/9090#discussion_r644609278
########## File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/AbstractRebuildIndexTest.java ########## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.index; + +import java.util.List; +import org.apache.ignite.Ignite; +import org.apache.ignite.IgniteCache; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.client.Person; +import org.apache.ignite.configuration.CacheConfiguration; +import org.apache.ignite.configuration.DataRegionConfiguration; +import org.apache.ignite.configuration.DataStorageConfiguration; +import org.apache.ignite.configuration.IgniteConfiguration; +import org.apache.ignite.failure.StopNodeFailureHandler; +import org.apache.ignite.internal.IgniteEx; +import org.apache.ignite.internal.IgniteInternalFuture; +import org.apache.ignite.internal.processors.cache.CacheMetricsImpl; +import org.apache.ignite.internal.processors.cache.GridCacheContext; +import org.apache.ignite.internal.processors.cache.index.IndexesRebuildTaskEx.BreakRebuildIndexConsumer; +import org.apache.ignite.internal.processors.cache.index.IndexesRebuildTaskEx.StopRebuildIndexConsumer; +import org.apache.ignite.internal.processors.cache.persistence.CacheDataRow; +import org.apache.ignite.internal.util.lang.IgniteThrowableBiPredicate; +import org.apache.ignite.internal.util.typedef.G; +import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; +import org.jetbrains.annotations.Nullable; + +import static java.util.stream.Collectors.toList; +import static org.apache.ignite.cluster.ClusterState.ACTIVE; +import static org.apache.ignite.internal.processors.cache.index.IndexesRebuildTaskEx.addCacheRowConsumer; +import static org.apache.ignite.internal.processors.cache.index.IndexesRebuildTaskEx.nodeName; +import static org.apache.ignite.testframework.GridTestUtils.deleteIndexBin; + +/** + * Base class for testing index rebuilds. + */ +public abstract class AbstractRebuildIndexTest extends GridCommonAbstractTest { + /** {@inheritDoc} */ + @Override protected void beforeTest() throws Exception { + super.beforeTest(); + + IndexesRebuildTaskEx.clean(getTestIgniteInstanceName()); + + stopAllGrids(); + cleanPersistenceDir(); + } + + /** {@inheritDoc} */ + @Override protected void afterTest() throws Exception { + super.afterTest(); + + IndexesRebuildTaskEx.clean(getTestIgniteInstanceName()); + + stopAllGrids(); + cleanPersistenceDir(); + } + + /** {@inheritDoc} */ + @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { + return super.getConfiguration(igniteInstanceName) + .setConsistentId(igniteInstanceName) + .setFailureHandler(new StopNodeFailureHandler()) + .setDataStorageConfiguration( + new DataStorageConfiguration() + .setDefaultDataRegionConfiguration(new DataRegionConfiguration().setPersistenceEnabled(true)) + ).setCacheConfiguration(cacheCfg(DEFAULT_CACHE_NAME, null)); + } + + /** {@inheritDoc} */ + @Override protected IgniteEx startGrid(int idx) throws Exception { + IgniteEx n = super.startGrid(idx); + + n.cluster().state(ACTIVE); + + return n; + } + + /** + * Prepare cluster for test. + * + * @param keys Key count. + * @return Coordinator. + * @throws Exception If failed. + */ + protected IgniteEx prepareCluster(int keys) throws Exception { + IgniteEx n = startGrid(0); + + if (n.cluster().state() != ACTIVE) Review comment: But `checkRestartRebuildIndexes` calls `startGrid(int)` which already activate the cluster and `ResumeRebuildIndexTest` do NOT override `startGrid(int)`. I think one line economy having a `prepareCluster(int)` instead of `startGrid(int); populateCache(int)` in tests saves nothing, but makes test code uncertain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
