alamar commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651613092
##########
File path:
modules/hibernate-4.2/src/test/java/org/apache/ignite/cache/hibernate/HibernateL2CacheTransactionalSelfTest.java
##########
@@ -75,7 +76,7 @@
/** {@inheritDoc} */
@Override protected void beforeTestsStarted() throws Exception {
- jotm = new Jotm(true, false);
+ jotm = new Jotm(true, false, new RmiLocalConfiguration());
Review comment:
What does it mean and why is it needed?
##########
File path: modules/urideploy/pom.xml
##########
@@ -111,13 +111,6 @@
<scope>test</scope>
</dependency>
- <dependency>
Review comment:
Removing ignite-tools may fail the suite since ignite-tools is needed to
assist their execution. Why?
##########
File path: modules/extdata/uri/pom.xml
##########
@@ -64,7 +64,27 @@
<module>modules/uri-dependency</module>
</modules>
+ <properties>
Review comment:
What is the reason for extdata-uri changes? Is it a simple refactoring?
##########
File path: parent/pom.xml
##########
@@ -293,9 +293,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <configuration>
Review comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
