vldpyatkov commented on a change in pull request #175:
URL: https://github.com/apache/ignite-3/pull/175#discussion_r654000659
##########
File path: modules/core/src/main/java/org/apache/ignite/lang/IgniteLogger.java
##########
@@ -55,15 +56,23 @@ protected IgniteLogger(@NotNull Class<?> cls) {
* @param params Parameters.
*/
public void info(String msg, Object... params) {
- log.log(INFO, msg, params);
+ if (log.isLoggable(INFO)) {
+ IgniteBiTuple<String, Throwable> readyParams = format(msg, params);
+
+ log.log(INFO, readyParams.get1(), readyParams.get1());
+ }
Review comment:
I slightly changed javadoc in order to allow to pass a Throwble in the
latest parameter.
I am not sure that API which require making format by hand would be more
pretty... Although, I want to see an opinion from anyone else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
