SammyVimes commented on a change in pull request #174:
URL: https://github.com/apache/ignite-3/pull/174#discussion_r656371539
##########
File path:
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java
##########
@@ -460,21 +447,13 @@ private long appliedRevision() throws
IgniteInternalCheckedException {
* @return Ignite UUID of new consolidated watch.
*/
private CompletableFuture<Optional<IgniteUuid>> updateWatches() {
- long revision;
- try {
- revision = appliedRevision() + 1;
- }
- catch (IgniteInternalCheckedException e) {
- throw new IgniteInternalException("Couldn't receive applied
revision during watch redeploy", e);
- }
-
- final var finalRevision = revision;
+ long revision = appliedRevision() + 1;
deployFut = deployFut
.thenCompose(idOpt -> idOpt.map(id ->
metaStorageSvcFut.thenCompose(svc -> svc.stopWatch(id))).
orElse(CompletableFuture.completedFuture(null))
.thenCompose(r -> {
- var watch = watchAggregator.watch(finalRevision,
this::storeEntries);
+ var watch = watchAggregator.watch(revision,
this::storeEntries);
Review comment:
should not be `var`
##########
File path:
modules/runner/src/main/java/org/apache/ignite/internal/app/IgnitionImpl.java
##########
@@ -177,7 +186,38 @@ else if (jsonStrBootstrapCfg != null)
ackSuccessStart();
- return new IgniteImpl(distributedTblMgr);
+ return new IgniteImpl(distributedTblMgr) {
+ @Override public void close() throws Exception {
+ super.close();
+
+ vaultMgr.close();
Review comment:
Why don't we move VaultManager to IgniteImpl so we can close it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
