sashapolo commented on a change in pull request #174:
URL: https://github.com/apache/ignite-3/pull/174#discussion_r659691498
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java
##########
@@ -328,14 +334,7 @@ public static ClassLoader igniteClassLoader() {
if (ldr == null)
ldr = igniteClassLoader;
- ConcurrentMap<String, Class<?>> ldrMap = classCache.get(ldr);
-
- if (ldrMap == null) {
- ConcurrentMap<String, Class<?>> old = classCache.putIfAbsent(ldr,
ldrMap = new ConcurrentHashMap<>());
-
- if (old != null)
- ldrMap = old;
- }
+ ConcurrentMap<String, Class<?>> ldrMap =
classCache.computeIfAbsent(ldr, k -> new ConcurrentHashMap<>());
Review comment:
https://bugs.openjdk.java.net/browse/JDK-8161372 - is this related?
Which article showed you that it might be a bottleneck? Anyway, I will rollback
this change since, strictly speaking, it is not required by this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]