NSAmelchev commented on a change in pull request #9195:
URL: https://github.com/apache/ignite/pull/9195#discussion_r660318248
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataRegionMetricsImpl.java
##########
@@ -726,6 +726,11 @@ public void clear() {
metrics.reset();
}
+ /** Removes all metric for data region. */
+ public void remove() {
+ kernalCtx.metric().remove(metricRegistry().name(), false);
Review comment:
I think code should not be refactored in this issue.
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsAddRemoveTest.java
##########
@@ -152,12 +200,25 @@ private void createCache(@Nullable String dataRegionName,
@Nullable String cache
if (cacheName != null)
ccfg.setName(cacheName);
+ if (groupName != null)
+ ccfg.setGroupName(groupName);
+
if (nearEnabled)
ccfg.setNearConfiguration(new NearCacheConfiguration());
grid("client").createCache(ccfg);
awaitPartitionMapExchange();
+
Review comment:
No, we can't. We should configure cache and near cache metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
