vveider commented on a change in pull request #98:
URL: https://github.com/apache/ignite-3/pull/98#discussion_r660564246



##########
File path: parent/pom.xml
##########
@@ -596,6 +596,7 @@
         <!--
             Profile to exclude running surefire (unit) tests but do not 
prevent running integration ones
         -->
+        <!--suppress MavenModelInspection -->

Review comment:
       What does explain this comment?

##########
File path: DEVNOTES.md
##########
@@ -28,9 +28,17 @@ Upon build completion, CLI tool can be found be under 
`modules/cli/target` direc
 Code style is checked with [Apache Maven Checkstyle 
Plugin](https://maven.apache.org/plugins/maven-checkstyle-plugin/).
 * [Checkstyle rules](check-rules/checkstyle-rules.xml)
 * [Checkstyle suppressions](check-rules/checkstyle-suppressions.xml)
+* [Checkstyle rules for 
javadocs](https://checkstyle.sourceforge.io/config_javadoc.html)
+
+Run code style checks:
 ```
 mvn clean checkstyle:checkstyle-aggregate
 ```
+
+Run javadoc style checks for public api:
+```
+mvn clean checkstyle:checkstyle-aggregate -P javadoc

Review comment:
       Where is declaration of `javadoc` profile?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to