ygerzhedovich commented on a change in pull request #9194:
URL: https://github.com/apache/ignite/pull/9194#discussion_r664631661



##########
File path: modules/calcite/src/test/sql/function/string/test_concat.test
##########
@@ -49,33 +46,30 @@ NULL
 NULL
 NULL
 
-# concat requires at least one argument
+# concat requires at least two argument
 statement error
 SELECT CONCAT()
 
 # concat with one argument works
-query T
+statement error
 SELECT CONCAT('hello')
-----
-hello
 
 # varargs concat
 query T
 SELECT CONCAT('hello', 33, 22)
 ----
 hello3322
 
-# CONCAT ignores null values
+# CONCAT with null
 query T
 SELECT CONCAT('hello', 33, NULL, 22, NULL)
 ----
-hello3322
+NULL

Review comment:
       I think such case should be fixed. I've created a ticket 
https://issues.apache.org/jira/browse/IGNITE-15066




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to