AMashenkov commented on a change in pull request #217:
URL: https://github.com/apache/ignite-3/pull/217#discussion_r673817966
##########
File path: modules/core/src/main/java/org/apache/ignite/lang/IgniteLogger.java
##########
@@ -195,7 +201,12 @@ private void logInternal(Level level, String msg,
Object... params) {
if (!log.isLoggable(level))
return;
- log.log(level, LoggerMessageHelper.arrayFormat(msg, params));
+ Throwable throwable =
LoggerMessageHelper.getThrowableCandidate(params);
+
+ if (throwable != null)
+ log.log(level, LoggerMessageHelper.arrayFormat(msg,
LoggerMessageHelper.trimmedCopy(params)), throwable);
+ else
+ log.log(level, LoggerMessageHelper.arrayFormat(msg, params));
Review comment:
Possible solutions are
- to drop and force a developer to format the message before the method call
or pass Supplier<String> for message
or wrap log() call with smth like "if (log.isLoggable())"
- rewrite with log(Level, String, Throwable, Object...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
