sanpwc commented on a change in pull request #197:
URL: https://github.com/apache/ignite-3/pull/197#discussion_r674157249
##########
File path: modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java
##########
@@ -53,51 +53,54 @@
*
* @param clusterNetSvc Cluster network service.
*/
- public Loza(ClusterService clusterNetSvc) {
+ public Loza(ClusterService clusterNetSvc, String dataPath) {
this.clusterNetSvc = clusterNetSvc;
- this.raftServer = new RaftServerImpl(clusterNetSvc, FACTORY);
+ this.raftServer = new JRaftServerImpl(clusterNetSvc, dataPath,
FACTORY);
}
/**
- * Creates a RAFT group.
+ * Creates a raft group service.
+ * If {@code nodes} contains the current node, then raft group starts on
the current node.
*
- * @param groupId RAFT group id.
- * @param peers Group peers.
- * @param lsnr Group listener.
- * @return A RAFT group client.
+ * @param groupId Raft group id.
+ * @param nodes Raft group nodes.
+ * @param lsnr Raft group listener.
+ * @return A service providing operations on a raft group.
*/
- public RaftGroupService startRaftGroup(String groupId, List<ClusterNode>
peers, RaftGroupListener lsnr) {
- assert !peers.isEmpty();
+ public RaftGroupService raftGroupService(String groupId, List<ClusterNode>
nodes, RaftGroupListener lsnr) {
Review comment:
I'd rather use prepareRaftGroup here instead of raftGroupService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
