sashapolo commented on a change in pull request #234:
URL: https://github.com/apache/ignite-3/pull/234#discussion_r674610044
##########
File path: parent/pom.xml
##########
@@ -1155,6 +1155,53 @@
</bottom>
</configuration>
</plugin>
+
+ <!--
+ Plugin to remove org.apache.ignite.* artifacts from local
repository before the build
+ (always clean build with current reactor dependency resolution)
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>purge-local-repository</id>
+ <phase>package</phase>
+ <goals>
+ <goal>purge-local-repository</goal>
+ </goals>
+ <configuration>
+ <manualIncludes>
+
<manualInclude>org.apache.ignite</manualInclude>
Review comment:
Won't this also remove dependencies from Ignite 2? Should we use
`include` instead?
##########
File path: parent/pom.xml
##########
@@ -1155,6 +1155,53 @@
</bottom>
</configuration>
</plugin>
+
+ <!--
+ Plugin to remove org.apache.ignite.* artifacts from local
repository before the build
+ (always clean build with current reactor dependency resolution)
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>purge-local-repository</id>
+ <phase>package</phase>
+ <goals>
+ <goal>purge-local-repository</goal>
+ </goals>
+ <configuration>
+ <manualIncludes>
+
<manualInclude>org.apache.ignite</manualInclude>
+ </manualIncludes>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+
+ <!--
+ Plugin to remove org.apache.ignite.* artifacts from local
repository before the build
+ (always clean build with current reactor dependency resolution)
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>purge-local-repository</id>
+ <phase>package</phase>
+ <goals>
+ <goal>purge-local-repository</goal>
+ </goals>
+ <configuration>
+ <manualIncludes>
+
<manualInclude>org.apache.ignite:${project.artifactId}</manualInclude>
Review comment:
Why do you need a separate plugin configuration for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
