ibessonov commented on a change in pull request #240:
URL: https://github.com/apache/ignite-3/pull/240#discussion_r675336730
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/annotation/ConfigurationRoot.java
##########
@@ -34,9 +34,17 @@
@Retention(RUNTIME)
@Documented
public @interface ConfigurationRoot {
- /** @return Unique root name. */
+ /**
+ * Returns unique root name.
Review comment:
I hope I fixed it right
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/notifications/ConfigurationNotificationEvent.java
##########
@@ -23,24 +23,31 @@
/**
* Event object propogated on configuration change. Passed to listeners after
configuration changes are applied.
*
+ * @param <VIEW> Type of the subtree or the value that has been changed.
* @see ConfigurationProperty#listen(ConfigurationListener)
* @see ConfigurationListener
* @see ConfigurationNotificationEvent
*/
public interface ConfigurationNotificationEvent<VIEW> {
/**
+ * Returns previous value of the updated configuration.
Review comment:
Done
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/annotation/ConfigurationRoot.java
##########
@@ -34,9 +34,17 @@
@Retention(RUNTIME)
@Documented
public @interface ConfigurationRoot {
- /** @return Unique root name. */
+ /**
+ * Returns unique root name.
Review comment:
I hope I fixed it correctly
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/validation/ValidationContext.java
##########
@@ -25,19 +25,34 @@
/**
* Validation context for the validators.
*
+ * @param <VIEW> Type of the subtree or the value that is being validated.
* @see Validator#validate(Annotation, ValidationContext)
*/
public interface ValidationContext<VIEW> {
- /** @return String representation of currently validated value, i.e.
{@code root.config.node} */
+ /**
+ * Returns key of validated node.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
