sk0x50 commented on a change in pull request #230:
URL: https://github.com/apache/ignite-3/pull/230#discussion_r676525355
##########
File path:
modules/runner/src/main/java/org/apache/ignite/internal/app/IgnitionImpl.java
##########
@@ -129,6 +147,24 @@
return doStart(name, null, workDir);
}
+ /** {@inheritDoc} */
+ @Override public void stop(@NotNull String name) {
Review comment:
It looks like we need to clearly specify the behavior in the case when a
node with the specified name is not found or the given name is empty.
Do we need to provide additional clarity for the end-user in this case
(return `false` value/ throw a new exception)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
