xtern commented on a change in pull request #9271:
URL: https://github.com/apache/ignite/pull/9271#discussion_r676848008



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/cache/query/PlatformContinuousQueryImpl.java
##########
@@ -142,8 +142,10 @@ private static CacheEntryEventFilter getJavaFilter(Object 
filter, GridKernalCont
 
                 qry.setLocalListener(this);
 
-                //noinspection deprecation
-                qry.setRemoteFilter(this); // Filter must be set always for 
correct resource release.
+                if (hasFilter || javaFilter != null) {
+                    //noinspection deprecation
+                    qry.setRemoteFilter(this); // Filter must be set always 
for correct resource release.

Review comment:
       Thanks for the clarification, I tried to prevent unnecessary 
serialization of the "security filter", but since the platform filter must 
always be set, it seems to me that the best solution would be to simply check 
for null in the "security filter".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to