ibessonov commented on a change in pull request #244:
URL: https://github.com/apache/ignite-3/pull/244#discussion_r678319677



##########
File path: 
modules/configuration-annotation-processor/src/test/java/org/apache/ignite/internal/configuration/tree/NamedListOrderTest.java
##########
@@ -231,9 +299,18 @@ public void creationErrors() throws Exception {
         assertThrows(IndexOutOfBoundsException.class, () -> b.create(-1, "Z", 
z -> {}));
         assertThrows(IndexOutOfBoundsException.class, () -> b.create(3, "Z", z 
-> {}));
 
-        // Create after delete.
+        // Nonexisting key.
+        assertThrows(IllegalArgumentException.class, () -> b.rename("A", "Z"));
+
+        // Operations after delete.
         b.delete("X");
         assertThrows(IllegalArgumentException.class, () -> b.create("X", x -> 
{}));
         assertThrows(IllegalArgumentException.class, () -> b.create(0, "X", x 
-> {}));
+        assertThrows(IllegalArgumentException.class, () -> b.rename("X", "Z"));
+        assertThrows(IllegalArgumentException.class, () -> b.rename("Y", "X"));
+
+        // Deletion of nonexistent elements doesn't break enything.

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to