sashapolo commented on a change in pull request #244:
URL: https://github.com/apache/ignite-3/pull/244#discussion_r678364388
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/NamedListChange.java
##########
@@ -82,7 +82,21 @@
NamedListChange<Change> createOrUpdate(String key, Consumer<Change>
valConsumer);
/**
- * Remove the value from named list configuration.
+ * Renames the existing value in the named list configuration.
+ *
+ * @param oldKey Key for the value to be updated.
+ * @param newKey New key for the same value.
+ * @return {@code this} for chaining.
+ *
+ * @throws NullPointerException If one of parameters is null.
+ * @throws IllegalArgumentException If an element with name {@code newKey}
already exists, or an element with name
+ * {@code oldKey} doesn't exits, or {@link #delete(String)} has been
invoked with the either {@code newKey}
Review comment:
ok, maybe this moment should be reflected in the javadoc
##########
File path:
modules/configuration-api/src/main/java/org/apache/ignite/configuration/NamedListChange.java
##########
@@ -82,7 +82,21 @@
NamedListChange<Change> createOrUpdate(String key, Consumer<Change>
valConsumer);
/**
- * Remove the value from named list configuration.
+ * Renames the existing value in the named list configuration.
+ *
+ * @param oldKey Key for the value to be updated.
+ * @param newKey New key for the same value.
+ * @return {@code this} for chaining.
+ *
+ * @throws NullPointerException If one of parameters is null.
+ * @throws IllegalArgumentException If an element with name {@code newKey}
already exists, or an element with name
+ * {@code oldKey} doesn't exits, or {@link #delete(String)} has been
invoked with the either {@code newKey}
Review comment:
ok, maybe this should be reflected in the javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
