ololo3000 commented on a change in pull request #9182:
URL: https://github.com/apache/ignite/pull/9182#discussion_r679108716
##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -286,23 +286,28 @@ Register name: `io.communication`
|SentBytesCount | long | Sent bytes count.
|ReceivedBytesCount| long| Received bytes count.
|ReceivedMessagesCount| integer| Received messages count.
-|RejectedSslSessionsCount| integer| TCP sessions count that were rejected
due to the SSL errors (metric is exported only if SSL is enabled).
+|RejectedSslSessions| integer| TCP sessions count that were rejected due
to the SSL errors (metric is exported only if SSL is enabled).
Review comment:
Here and below. The metric name doesn't match
GridNioSslFilter#SSL_REJECTED_SESSIONS_CNT_METRIC_NAME value.
RejectedSslSessions vs RejectedSslSessionsCount
##########
File path: docs/_docs/monitoring-metrics/new-metrics.adoc
##########
@@ -286,23 +286,28 @@ Register name: `io.communication`
|SentBytesCount | long | Sent bytes count.
|ReceivedBytesCount| long| Received bytes count.
|ReceivedMessagesCount| integer| Received messages count.
-|RejectedSslSessionsCount| integer| TCP sessions count that were rejected
due to the SSL errors (metric is exported only if SSL is enabled).
+|RejectedSslSessions| integer| TCP sessions count that were rejected due
to the SSL errors (metric is exported only if SSL is enabled).
|SslEnabled| boolean| Indicates whether SSL is enabled.
|SslHandshakeDurationHistogram| histogram| Histogram of SSL handshake
duration in milliseconds (metric is exported only if SSL is enabled).
|===
== Ignite Thin Client Connector
-Register name: `connector.client.thin.tcp`
+Register name: `client.connector`
[cols="2,1,3",opts="header"]
|===
|Name| Type| Description
|ActiveSessionsCount| integer| Active TCP sessions count.
|ReceivedBytesCount| long| Received bytes count.
-|RejectedSslSessionsCount| integer| TCP sessions count that were rejected
due to the SSL errors (metric is exported only if SSL is enabled).
+|RejectedSslSessions| integer| TCP sessions count that were rejected due
to the SSL errors (metric is exported only if SSL is enabled).
+|RejectedSessionsByTimeout| integer| TCP sessions count that were rejected
due to handshake timeout.
+|RejectedSessionsDueAuthentication| integer| TCP sessions count that were
rejected due to failed authentication.
+|RejectedSessionsTotal| integer| Total number of rejected TCP connections.
+|{clientType}.AcceptedSessions| integer| Number of successfully
established sessions.
Review comment:
{clientType}.AcceptedSessions
{clientType}.ActiveSessions
Let's point in the description that it's number of sessions that belongs to
particular connection type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
