ibessonov commented on a change in pull request #244:
URL: https://github.com/apache/ignite-3/pull/244#discussion_r679783763
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationNotificationsUtil.java
##########
@@ -149,29 +219,32 @@ public static void notifyListeners(
/**
* Invoke {@link
ConfigurationListener#onUpdate(ConfigurationNotificationEvent)} on all passed
listeners and put
* results in {@code futures}. Not recursively.
+ *
* @param listeners List o flisteners.
* @param oldVal Old configuration value.
* @param newVal New configuration value.
* @param storageRevision Storage revision.
* @param futures Write-only list of futures.
* @param <V> Type of the node.
+ * @param <L> Type of the configuration listener.
*/
- private static <V> void notifyPublicListeners(
- List<? extends ConfigurationListener<V>> listeners,
+ private static <V, L extends ConfigurationListener<V>> void
notifyPublicListeners(
+ List<? extends L> listeners,
V oldVal,
V newVal,
long storageRevision,
- List<CompletableFuture<?>> futures
+ List<CompletableFuture<?>> futures,
+ BiFunction<L, ConfigurationNotificationEvent<V>, CompletableFuture<?>>
updater
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
