sk0x50 commented on a change in pull request #256:
URL: https://github.com/apache/ignite-3/pull/256#discussion_r685776553
##########
File path: modules/api/src/main/java/org/apache/ignite/app/IgnitionManager.java
##########
@@ -38,9 +38,24 @@
/**
* Starts an Ignite node with an optional bootstrap configuration from a
HOCON file.
*
- * @param nodeName Name of the node. Must not be {@code null}.
- * @param configStr Node configuration in the HOCON format. Can be {@code
null}.
- * @param workDir Work directory for the started node. Must not be {@code
null}.
+ * @param nodeName Name of the node. Must not be {@code null}.
+ * @param configStr Optional node configuration based on
+ * {@link
org.apache.ignite.configuration.schemas.runner.NodeConfigurationSchema} and
+ * {@link
org.apache.ignite.configuration.schemas.network.NetworkConfigurationSchema}.
+ * Following rules are used for applying the
configuration properties:
+ * <ol>
+ * <li>Specified property overrides existing one or
just applies itself if it wasn't
+ * previously specified.</li>
+ * <li>All non-specified properties either use
previous value or use default one from
+ * corresponding configuration schema </li>
Review comment:
```suggestion
* corresponding configuration schema.</li>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
