ptupitsyn commented on a change in pull request #9307:
URL: https://github.com/apache/ignite/pull/9307#discussion_r687605685
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -125,6 +126,11 @@ private TcpIgniteClient(ClientConfiguration cfg) throws
ClientException {
ch.channelsInit();
ch.addChannelFailListener(metadataHnd::onReconnect);
+ // Binary descriptors and user types caches must be cleared so
that the
+ // client will register all the user types within the cluster once
again in case this information
+ // was lost during the cluster failover.
+ ch.addChannelFailListener(marshCtx::clearUserTypesCache);
Review comment:
We can add use one fail listener to perform all tasks instead of adding
three of them.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java
##########
@@ -1437,6 +1440,7 @@ public void onUndeploy(ClassLoader ldr) {
it.remove();
}
}
+ optmMarsh.onUndeploy(ldr);
Review comment:
Missing blank line after the block.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -125,6 +126,11 @@ private TcpIgniteClient(ClientConfiguration cfg) throws
ClientException {
ch.channelsInit();
ch.addChannelFailListener(metadataHnd::onReconnect);
+ // Binary descriptors and user types caches must be cleared so
that the
Review comment:
Missing blank line before the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
