tledkov-gridgain commented on a change in pull request #9143:
URL: https://github.com/apache/ignite/pull/9143#discussion_r687637844
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdCollation.java
##########
@@ -548,9 +548,9 @@ public int compare(List<RexLiteral> o1, List<RexLiteral>
o2) {
case FULL:
for (RelCollation collation : leftCollations) {
for (RelFieldCollation field :
collation.getFieldCollations()) {
- if (!(RelFieldCollation.NullDirection.LAST ==
field.nullDirection)) {
+ if
(!(RelFieldCollation.NullDirection.LAST.nullComparison ==
Review comment:
If any method `enumerable<NodeName>` is called by Ignite optimizer?
Should they are removed?
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdCollation.java
##########
@@ -548,9 +548,9 @@ public int compare(List<RexLiteral> o1, List<RexLiteral>
o2) {
case FULL:
for (RelCollation collation : leftCollations) {
for (RelFieldCollation field :
collation.getFieldCollations()) {
- if (!(RelFieldCollation.NullDirection.LAST ==
field.nullDirection)) {
+ if
(!(RelFieldCollation.NullDirection.LAST.nullComparison ==
Review comment:
Is any method `enumerable<NodeName>` is called by Ignite optimizer?
Should they are removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
