SammyVimes commented on a change in pull request #272:
URL: https://github.com/apache/ignite-3/pull/272#discussion_r688342064



##########
File path: 
modules/raft-client/src/main/java/org/apache/ignite/raft/client/service/impl/RaftGroupServiceImpl.java
##########
@@ -88,24 +88,26 @@
     private final long retryDelay;
 
     /** */
-    private final ScheduledExecutorService executor = 
Executors.newScheduledThreadPool(1);
+    private static final ScheduledExecutorService executor = 
Executors.newScheduledThreadPool(1);

Review comment:
       well, if every raft group has its own scheduler, we end up with 1024 
schedulers for one table. We can live it as it is for now, but it sure needs 
some refactoring




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to