ibessonov commented on a change in pull request #272:
URL: https://github.com/apache/ignite-3/pull/272#discussion_r689282411
##########
File path:
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ITSimpleCounterServerTest.java
##########
@@ -103,39 +105,29 @@ void before(TestInfo testInfo) {
ClusterService clientNode1 = clusterService("localhost:" + (PORT + 1),
PORT + 1, List.of(addr), true);
- client1 = new RaftGroupServiceImpl(COUNTER_GROUP_ID_0, clientNode1,
FACTORY, 1000,
- List.of(new Peer(serverNode.address())), false, 200) {
- @Override public void shutdown() {
- super.shutdown();
-
- clientNode1.stop();
- }
- };
+ client1 = RaftGroupServiceImpl.start(COUNTER_GROUP_ID_0, clientNode1,
FACTORY, 1000,
+ List.of(new Peer(serverNode.address())), false, 200).get(3,
TimeUnit.SECONDS);
ClusterService clientNode2 = clusterService("localhost:" + (PORT + 2),
PORT + 2, List.of(addr), true);
- client2 = new RaftGroupServiceImpl(COUNTER_GROUP_ID_1, clientNode2,
FACTORY, 1000,
- List.of(new Peer(serverNode.address())), false, 200) {
- @Override public void shutdown() {
- super.shutdown();
-
- clientNode2.stop();
- }
- };
+ client2 = RaftGroupServiceImpl.start(COUNTER_GROUP_ID_1, clientNode2,
FACTORY, 1000,
+ List.of(new Peer(serverNode.address())), false, 200).get(3,
TimeUnit.SECONDS);
assertTrue(waitForTopology(service, 2, 1000));
assertTrue(waitForTopology(clientNode1, 2, 1000));
assertTrue(waitForTopology(clientNode2, 2, 1000));
}
/**
- * @throws Exception
+ * @throws Exception If failed.
*/
@AfterEach
- void after() throws Exception {
+ @Override public void after(TestInfo testInfo) throws Exception {
Review comment:
Why do you override "after" but not "before"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
