Berkof commented on a change in pull request #9276:
URL: https://github.com/apache/ignite/pull/9276#discussion_r681444994



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdColumnOrigins.java
##########
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.metadata;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import org.apache.calcite.plan.RelOptTable;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Aggregate;
+import org.apache.calcite.rel.core.AggregateCall;
+import org.apache.calcite.rel.core.Calc;
+import org.apache.calcite.rel.core.Exchange;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.core.SetOp;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rel.core.TableFunctionScan;
+import org.apache.calcite.rel.core.TableModify;
+import org.apache.calcite.rel.metadata.BuiltInMetadata;
+import org.apache.calcite.rel.metadata.MetadataDef;
+import org.apache.calcite.rel.metadata.MetadataHandler;
+import org.apache.calcite.rel.metadata.ReflectiveRelMetadataProvider;
+import org.apache.calcite.rel.metadata.RelColumnMapping;
+import org.apache.calcite.rel.metadata.RelColumnOrigin;
+import org.apache.calcite.rel.metadata.RelMetadataProvider;
+import org.apache.calcite.rel.metadata.RelMetadataQuery;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexLocalRef;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexShuttle;
+import org.apache.calcite.rex.RexVisitor;
+import org.apache.calcite.rex.RexVisitorImpl;
+import org.apache.calcite.util.BuiltInMethod;
+import org.apache.ignite.internal.processors.query.calcite.rel.IgniteIndexScan;
+import org.apache.ignite.internal.processors.query.calcite.rel.IgniteTableScan;
+import org.apache.ignite.internal.processors.query.calcite.schema.IgniteTable;
+import org.checkerframework.checker.nullness.qual.Nullable;
+import org.checkerframework.checker.nullness.qual.PolyNull;
+
+/**
+ * RelMdColumnOrigins supplies a default implementation of
+ * {@link RelMetadataQuery#getColumnOrigins} for the standard logical algebra.
+ */
+public class IgniteMdColumnOrigins
+    implements MetadataHandler<BuiltInMetadata.ColumnOrigin> {
+    public static final RelMetadataProvider SOURCE =
+        ReflectiveRelMetadataProvider.reflectiveSource(
+            BuiltInMethod.COLUMN_ORIGIN.method, new IgniteMdColumnOrigins());
+
+    //~ Constructors 
-----------------------------------------------------------
+
+    private IgniteMdColumnOrigins() {}
+
+    //~ Methods 
----------------------------------------------------------------
+
+    @Override public MetadataDef<BuiltInMetadata.ColumnOrigin> getDef() {
+        return BuiltInMetadata.ColumnOrigin.DEF;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Aggregate rel, 
RelMetadataQuery mq, int iOutputColumn) {
+
+        if (iOutputColumn < rel.getGroupCount()) {
+            // get actual index of Group columns.
+            return mq.getColumnOrigins(rel.getInput(), 
rel.getGroupSet().asList().get(iOutputColumn));
+        }
+
+        // Aggregate columns are derived from input columns
+        AggregateCall call = rel.getAggCallList().get(iOutputColumn - 
rel.getGroupCount());
+
+        final Set<RelColumnOrigin> set = new HashSet<>();
+
+        for (Integer iInput : call.getArgList()) {
+            Set<RelColumnOrigin> inputSet = 
mq.getColumnOrigins(rel.getInput(), iInput);
+            inputSet = createDerivedColumnOrigins(inputSet);
+
+            if (inputSet != null)
+                set.addAll(inputSet);
+
+        }
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Join rel, 
RelMetadataQuery mq,
+        int iOutputColumn) {
+        int nLeftColumns = rel.getLeft().getRowType().getFieldList().size();
+        Set<RelColumnOrigin> set;
+        boolean derived = false;
+
+        if (iOutputColumn < nLeftColumns) {
+            set = mq.getColumnOrigins(rel.getLeft(), iOutputColumn);
+
+            if (rel.getJoinType().generatesNullsOnLeft())
+                derived = true;
+
+        }
+        else {
+            set = mq.getColumnOrigins(rel.getRight(), iOutputColumn - 
nLeftColumns);
+
+            if (rel.getJoinType().generatesNullsOnRight())
+                derived = true;
+        }
+
+        if (derived) {
+            // nulls are generated due to outer join; that counts
+            // as derivation
+            set = createDerivedColumnOrigins(set);
+        }
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(SetOp rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        final Set<RelColumnOrigin> set = new HashSet<>();
+
+        for (RelNode input : rel.getInputs()) {
+            Set<RelColumnOrigin> inputSet = mq.getColumnOrigins(input, 
iOutputColumn);
+
+            if (inputSet == null)
+                return null;
+
+            set.addAll(inputSet);
+        }
+
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Project rel,
+        final RelMetadataQuery mq, int iOutputColumn) {
+        final RelNode input = rel.getInput();
+        RexNode rexNode = rel.getProjects().get(iOutputColumn);
+
+        if (rexNode instanceof RexInputRef) {
+            // Direct reference:  no derivation added.
+            RexInputRef inputRef = (RexInputRef) rexNode;
+
+            return mq.getColumnOrigins(input, inputRef.getIndex());
+        }
+        // Anything else is a derivation, possibly from multiple columns.
+        final Set<RelColumnOrigin> set = getMultipleColumns(rexNode, input, 
mq);
+
+        return createDerivedColumnOrigins(set);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Calc rel,
+        final RelMetadataQuery mq, int iOutputColumn) {
+        final RelNode input = rel.getInput();
+        final RexShuttle rexShuttle = new RexShuttle() {
+            @Override public RexNode visitLocalRef(RexLocalRef localRef) {
+                return rel.getProgram().expandLocalRef(localRef);
+            }
+        };
+        final List<RexNode> projects = new ArrayList<>();
+
+        for (RexNode rex: rexShuttle.apply(rel.getProgram().getProjectList()))
+            projects.add(rex);
+
+        final RexNode rexNode = projects.get(iOutputColumn);
+
+        if (rexNode instanceof RexInputRef) {
+            // Direct reference:  no derivation added.
+            RexInputRef inputRef = (RexInputRef) rexNode;
+            return mq.getColumnOrigins(input, inputRef.getIndex());
+        }
+        // Anything else is a derivation, possibly from multiple columns.
+        final Set<RelColumnOrigin> set = getMultipleColumns(rexNode, input, 
mq);
+
+        return createDerivedColumnOrigins(set);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Filter rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Sort rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableModify rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Exchange rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableFunctionScan 
rel,
+        RelMetadataQuery mq, int iOutputColumn) {
+        final Set<RelColumnOrigin> set = new HashSet<>();
+        Set<RelColumnMapping> mappings = rel.getColumnMappings();
+
+        if (mappings == null) {
+            if (!rel.getInputs().isEmpty()) {
+                // This is a non-leaf transformation:  say we don't
+                // know about origins, because there are probably
+                // columns below.
+                return null;
+            }
+            else {
+                // This is a leaf transformation: say there are fer sure no
+                // column origins.
+                return set;
+            }
+        }
+        for (RelColumnMapping mapping : mappings) {
+            if (mapping.iOutputColumn != iOutputColumn)
+                continue;
+
+            final RelNode input = rel.getInputs().get(mapping.iInputRel);
+            final int column = mapping.iInputColumn;
+            Set<RelColumnOrigin> origins = mq.getColumnOrigins(input, column);
+
+            if (origins == null)
+                return null;
+
+            if (mapping.derived)
+                origins = createDerivedColumnOrigins(origins);
+
+            set.addAll(origins);
+        }
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(IgniteIndexScan 
rel, RelMetadataQuery mq, int iOutputColumn) {
+        IgniteTable tbl = rel.getTable().unwrap(IgniteTable.class);
+
+        int originColIdx = (rel.requiredColumns() == null) ? iOutputColumn : 
rel.requiredColumns().toArray()[iOutputColumn];
+
+        return Collections.singleton(new RelColumnOrigin(rel.getTable(), 
originColIdx, false));
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(IgniteTableScan 
rel, RelMetadataQuery mq, int iOutputColumn) {
+        IgniteTable tbl = rel.getTable().unwrap(IgniteTable.class);
+
+        int originColIdx = (rel.requiredColumns() == null) ? iOutputColumn : 
rel.requiredColumns().toArray()[iOutputColumn];
+
+        return Collections.singleton(new RelColumnOrigin(rel.getTable(), 
originColIdx, false));
+    }
+
+    // Catch-all rule when none of the others apply.
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(RelNode rel,
+        RelMetadataQuery mq, int iOutputColumn) {
+        // NOTE jvs 28-Mar-2006: We may get this wrong for a physical table
+        // expression which supports projections.  In that case,
+        // it's up to the plugin writer to override with the
+        // correct information.
+
+        if (!rel.getInputs().isEmpty()) {
+            // No generic logic available for non-leaf rels.
+            return null;
+        }
+
+        final Set<RelColumnOrigin> set = new HashSet<>();
+
+        RelOptTable table = rel.getTable();
+        if (table == null) {
+            // Somebody is making column values up out of thin air, like a

Review comment:
       Suppose it for queries like "select * from (values(1,2,3), (2,1,3), 
(3,3,3)) t1 (c1,c2,c3)" which transform into RelNode: IgniteValues. I've just 
copy it from Calcite code.

##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ArrayRowHandler.java
##########
@@ -33,7 +33,7 @@ private ArrayRowHandler() {}
 
     /** {@inheritDoc} */
     @Override public Object get(int field, Object[] row) {
-        return row[field];
+        return (row == null) ? null : row[field];

Review comment:
       AbstractIndexScan.iterator(): logic definitely can pass null here.

##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdColumnOrigins.java
##########
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.calcite.metadata;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import org.apache.calcite.plan.RelOptTable;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Aggregate;
+import org.apache.calcite.rel.core.AggregateCall;
+import org.apache.calcite.rel.core.Calc;
+import org.apache.calcite.rel.core.Exchange;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Join;
+import org.apache.calcite.rel.core.Project;
+import org.apache.calcite.rel.core.SetOp;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rel.core.TableFunctionScan;
+import org.apache.calcite.rel.core.TableModify;
+import org.apache.calcite.rel.metadata.BuiltInMetadata;
+import org.apache.calcite.rel.metadata.MetadataDef;
+import org.apache.calcite.rel.metadata.MetadataHandler;
+import org.apache.calcite.rel.metadata.ReflectiveRelMetadataProvider;
+import org.apache.calcite.rel.metadata.RelColumnMapping;
+import org.apache.calcite.rel.metadata.RelColumnOrigin;
+import org.apache.calcite.rel.metadata.RelMetadataProvider;
+import org.apache.calcite.rel.metadata.RelMetadataQuery;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexLocalRef;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexShuttle;
+import org.apache.calcite.rex.RexVisitor;
+import org.apache.calcite.rex.RexVisitorImpl;
+import org.apache.calcite.util.BuiltInMethod;
+import org.apache.ignite.internal.processors.query.calcite.rel.IgniteIndexScan;
+import org.apache.ignite.internal.processors.query.calcite.rel.IgniteTableScan;
+import org.apache.ignite.internal.processors.query.calcite.schema.IgniteTable;
+import org.checkerframework.checker.nullness.qual.Nullable;
+import org.checkerframework.checker.nullness.qual.PolyNull;
+
+/**
+ * RelMdColumnOrigins supplies a default implementation of
+ * {@link RelMetadataQuery#getColumnOrigins} for the standard logical algebra.
+ */
+public class IgniteMdColumnOrigins
+    implements MetadataHandler<BuiltInMetadata.ColumnOrigin> {
+    public static final RelMetadataProvider SOURCE =
+        ReflectiveRelMetadataProvider.reflectiveSource(
+            BuiltInMethod.COLUMN_ORIGIN.method, new IgniteMdColumnOrigins());
+
+    //~ Constructors 
-----------------------------------------------------------
+
+    private IgniteMdColumnOrigins() {}
+
+    //~ Methods 
----------------------------------------------------------------
+
+    @Override public MetadataDef<BuiltInMetadata.ColumnOrigin> getDef() {
+        return BuiltInMetadata.ColumnOrigin.DEF;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Aggregate rel, 
RelMetadataQuery mq, int iOutputColumn) {
+
+        if (iOutputColumn < rel.getGroupCount()) {
+            // get actual index of Group columns.
+            return mq.getColumnOrigins(rel.getInput(), 
rel.getGroupSet().asList().get(iOutputColumn));
+        }
+
+        // Aggregate columns are derived from input columns
+        AggregateCall call = rel.getAggCallList().get(iOutputColumn - 
rel.getGroupCount());
+
+        final Set<RelColumnOrigin> set = new HashSet<>();
+
+        for (Integer iInput : call.getArgList()) {
+            Set<RelColumnOrigin> inputSet = 
mq.getColumnOrigins(rel.getInput(), iInput);
+            inputSet = createDerivedColumnOrigins(inputSet);
+
+            if (inputSet != null)
+                set.addAll(inputSet);
+
+        }
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Join rel, 
RelMetadataQuery mq,
+        int iOutputColumn) {
+        int nLeftColumns = rel.getLeft().getRowType().getFieldList().size();
+        Set<RelColumnOrigin> set;
+        boolean derived = false;
+
+        if (iOutputColumn < nLeftColumns) {
+            set = mq.getColumnOrigins(rel.getLeft(), iOutputColumn);
+
+            if (rel.getJoinType().generatesNullsOnLeft())
+                derived = true;
+
+        }
+        else {
+            set = mq.getColumnOrigins(rel.getRight(), iOutputColumn - 
nLeftColumns);
+
+            if (rel.getJoinType().generatesNullsOnRight())
+                derived = true;
+        }
+
+        if (derived) {
+            // nulls are generated due to outer join; that counts
+            // as derivation
+            set = createDerivedColumnOrigins(set);
+        }
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(SetOp rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        final Set<RelColumnOrigin> set = new HashSet<>();
+
+        for (RelNode input : rel.getInputs()) {
+            Set<RelColumnOrigin> inputSet = mq.getColumnOrigins(input, 
iOutputColumn);
+
+            if (inputSet == null)
+                return null;
+
+            set.addAll(inputSet);
+        }
+
+        return set;
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Project rel,
+        final RelMetadataQuery mq, int iOutputColumn) {
+        final RelNode input = rel.getInput();
+        RexNode rexNode = rel.getProjects().get(iOutputColumn);
+
+        if (rexNode instanceof RexInputRef) {
+            // Direct reference:  no derivation added.
+            RexInputRef inputRef = (RexInputRef) rexNode;
+
+            return mq.getColumnOrigins(input, inputRef.getIndex());
+        }
+        // Anything else is a derivation, possibly from multiple columns.
+        final Set<RelColumnOrigin> set = getMultipleColumns(rexNode, input, 
mq);
+
+        return createDerivedColumnOrigins(set);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Calc rel,
+        final RelMetadataQuery mq, int iOutputColumn) {
+        final RelNode input = rel.getInput();
+        final RexShuttle rexShuttle = new RexShuttle() {
+            @Override public RexNode visitLocalRef(RexLocalRef localRef) {
+                return rel.getProgram().expandLocalRef(localRef);
+            }
+        };
+        final List<RexNode> projects = new ArrayList<>();
+
+        for (RexNode rex: rexShuttle.apply(rel.getProgram().getProjectList()))
+            projects.add(rex);
+
+        final RexNode rexNode = projects.get(iOutputColumn);
+
+        if (rexNode instanceof RexInputRef) {
+            // Direct reference:  no derivation added.
+            RexInputRef inputRef = (RexInputRef) rexNode;
+            return mq.getColumnOrigins(input, inputRef.getIndex());
+        }
+        // Anything else is a derivation, possibly from multiple columns.
+        final Set<RelColumnOrigin> set = getMultipleColumns(rexNode, input, 
mq);
+
+        return createDerivedColumnOrigins(set);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Filter rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Sort rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableModify rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(Exchange rel, 
RelMetadataQuery mq, int iOutputColumn) {
+        return mq.getColumnOrigins(rel.getInput(), iOutputColumn);
+    }
+
+    public @Nullable Set<RelColumnOrigin> getColumnOrigins(TableFunctionScan 
rel,
+        RelMetadataQuery mq, int iOutputColumn) {
+        final Set<RelColumnOrigin> set = new HashSet<>();

Review comment:
       Set construction moved down.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to