Mmuzaf commented on a change in pull request #9317:
URL: https://github.com/apache/ignite/pull/9317#discussion_r692417895
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/pagemem/store/IgnitePageStoreManager.java
##########
@@ -100,7 +100,7 @@ public void initializeForCache(CacheGroupDescriptor
grpDesc, StoredCacheData cac
* @param tag Partition tag (growing 1-based partition file version).
* @throws IgniteCheckedException If failed to handle partition destroy
callback.
*/
- public void onPartitionDestroyed(int grpId, int partId, int tag) throws
IgniteCheckedException;
+ public void truncate(int grpId, int partId, int tag) throws
IgniteCheckedException;
Review comment:
I suggest keeping this `as is`. Currently, the method naming has a too
broader scope, so it's hard identify what's exactly happening under the hood
without reading the method implementation.
The `onPartitionCreated ` is not used at all, I've removed them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
