AMashenkov edited a comment on pull request #282: URL: https://github.com/apache/ignite-3/pull/282#issuecomment-906201451
@ptupitsyn > I think it should be internal. Tuple.create is enough for the public API. We have no internal package in ignite-api modules. So, TupleImpl should be moved to ignite-table module, but ignite-api doesn't depends on ignite-table. Thus, we need a way to create TupleImple from api module. > > Do we really need mutable tuple for a row (or for a key at least)? > Why not? It gives more flexibility to the user. I mean do we need 2 wrappers over the Row: 1-st SchemaAware immutable tuple for using Client handler/protocol, but wrap to a 2-nd mutable adapter (which is not schema aware) when returning to a user. This will make code clean, as for now we have to check if tuple is schema aware and then check if the schema is not 'null'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
