AMashenkov commented on pull request #296: URL: https://github.com/apache/ignite-3/pull/296#issuecomment-907053875
@ptupitsyn I've found a bug due to some base Java types were not fully supported in ClientMessagePacker.packObject(Object). I fixed the bug and add a test ClientMessagePackerUnpackerTest.testVariousTypesSupport(). The test approach doesn't looks good as unpack() method requires type-codes that enum resides in another module. It looks straightforward for me a client may needs a method for extracting a type from an object, but I failed to find the one. Moving test to client-handler package or moving conversion method ClientTableCommon.getClientDataType looks weird for me. So, I've just left the test as is. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
