ibessonov commented on a change in pull request #297:
URL: https://github.com/apache/ignite-3/pull/297#discussion_r701782978
##########
File path:
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorage.java
##########
@@ -462,7 +472,7 @@ private ScanCursor(RocksIterator iter, Predicate<SearchRow>
filter) {
/** {@inheritDoc} */
@Override public boolean hasNext() {
- while (isValid() && !filter.test(new SimpleDataRow(iter.key(),
null)))
+ while (isValid() && !filter.test(new SimpleDataRow(iter.key(),
iter.value())))
Review comment:
I couldn't find how exactly iterator reads the value. It might involve
unnecessary IO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
