AMashenkov commented on a change in pull request #309:
URL: https://github.com/apache/ignite-3/pull/309#discussion_r703330900
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/ddl/CreateTableCommand.java
##########
@@ -273,30 +118,16 @@ public void ifNotExists(boolean ifNotExists) {
}
/**
- * @return Data region name.
- */
- public String dataRegionName() {
- return dataRegionName;
- }
-
- /**
- * @param dataRegionName Data region name.
- */
- public void dataRegionName(String dataRegionName) {
- this.dataRegionName = dataRegionName;
- }
-
- /**
- * @return Encrypted flag.
+ * @return Primary key columns.
*/
- public boolean encrypted() {
- return encrypted;
+ public List<String> primaryKeyColumns() {
Review comment:
Is it possible to make return types consistent in the next method's
signatures?
`List<String> primaryKeyColumns` and `public Column[] columns() `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
